Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: New theme yasnaya by ParmuzinAlexander #420

Merged
merged 4 commits into from
Nov 8, 2018

Conversation

zsalch
Copy link
Contributor

@zsalch zsalch commented Nov 3, 2018

New theme 'yasnaya' by @ParmuzinAlexander
As discussion: #385

Because the 'board1.png' already as the default board, so use the 'board7.png':

image

  1. Allow user turn on/off the border by option 'show-border', default is turn off.

  2. And new theme options are added:

"winrate-stroke-width": 2,
"minimum-blunder-bar-width": 3,
"comment-background-color": [0, 0, 0, 200],
"comment-font-color": [255, 255, 255, 200],
"comment-node-color": [0, 0, 255, 200],
"winrate-line-color": [0, 255, 0, 200],
"winrate-miss-line-color": [0, 0, 255, 200],
"blunder-bar-color": [255, 0, 0, 200],
"blunder-winrate-thresholds":[-30,-20,-10,-5,5,10],
"blunder-node-colors":[[255,0,0,200],[0,255,0,200],[0,0,255],[255,255,0],[0,255,255],[255,0,255]]

  1. and font setup:
    "ui-font-name": "Wawati SC",
    "winrate-font-name": "Wawati SC Bold",
    "font-name": "Wawati SC",

PS: above the options are effective for both config.txt & theme.txt

@ParmuzinAlexander
About these new options, do you have some better suggestion?

@ParmuzinAlexander
Copy link
Contributor

ParmuzinAlexander commented Nov 4, 2018

@zsalch
Everything is fine except the font in the screenshot. But I see normal font with "Wawati SC". Font should be clear and understandable.
P.S. Ideally, I would like to remove border from board. Lizzie copied this from Sabaki, but this is a bad. The border is nowhere in other programs or the real Board. But you've already done a lot of work, I don't want to ask for anything else.

@zsalch
Copy link
Contributor Author

zsalch commented Nov 4, 2018

The wawati SC just a test font, current the theme 'yasnaya' does not setup a font, it will use default font.

@zsalch
Copy link
Contributor Author

zsalch commented Nov 4, 2018

The board border seems to have been there, not this change.
No board border, do you mean like following? Maybe we should allow the user to remove all the borders, because now almost all panels have it.
image

@ParmuzinAlexander
Copy link
Contributor

@zsalch
It's perfect!

@ParmuzinAlexander
Copy link
Contributor

@zsalch
I replaced board7 to the original texture. But it is not very important, visually they are the same.

@featurecat
Copy link
Owner

I added a default config option: theme: "default" so that it can easily be changed.

@featurecat featurecat merged commit d8a3c8c into featurecat:next Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants